feat: [ISSUE-1401]: Added helm get values option in Helm collector #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
banjoh
requested changes
Dec 19, 2023
There was a problem hiding this comment.
Thanks a lot for your contribution!
The overall change looks good to me. I have added some comments, mostly around cleanup and some improvements I noticed that need to be done
The other missing bit that would be needed in this PR is
- Documenting the helm collector in this file
- Updating this e2e test. It will involve adding some values the helm test fixture and passing in some values which you will assert their existence here
banjoh
reviewed
Jan 8, 2024
Signed-off-by: Akash Shrivastava <[email protected]>
Signed-off-by: Akash Shrivastava <[email protected]>
Signed-off-by: Akash Shrivastava <[email protected]>
|
Docs PR: replicatedhq/troubleshoot.sh#534 |
banjoh
requested changes
Jan 12, 2024
Signed-off-by: Akash Shrivastava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
This PR adds the helm values collection enhancement to Helm collector.
For more information, refer to this issue: #1401
Checklist
Does this PR introduce a breaking change?